Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(BA-722): set webserver config for showing kernel list in session detail panel #3671

Merged
merged 1 commit into from
Feb 18, 2025
Merged

feat(BA-722): set webserver config for showing kernel list in session detail panel #3671

merged 1 commit into from
Feb 18, 2025

Conversation

ironAiken2
Copy link
Contributor

@ironAiken2 ironAiken2 commented Feb 12, 2025 •
edited by agatha197
Loading

resolves #3668(BA-722)
related PR: lablup/backend.ai-webui#3081

Add show_kernel_list option to webserver config file to display or hide the kernel list in the session detail panel.

Add configs not specified in sample.toml

Checklist: (if applicable)

  • Milestone metadata specifying the target backport version
  • Mention to the original issue
  • Installer updates including:
    • Fixtures for db schema changes
    • New mandatory config options
  • Update of end-to-end CLI integration tests in ai.backend.test
  • API server-client counterparts (e.g., manager API -> client SDK)
  • Test case(s) to:
    • Demonstrate the difference of before/after
    • Demonstrate the flow of abstract/conceptual models with a concrete implementation
  • Documentation
    • Contents in the docs directory
    • docstrings in public interfaces and type annotations

@github-actions github-actions bot added the comp:webserver Related to Web Server component label Feb 12, 2025
@ironAiken2 Graphite App
Copy link
Contributor Author

This stack of pull requests is managed by Graphite. Learn more about stacking.

@github-actions github-actions bot added the size:S 10~30 LoC label Feb 12, 2025
@ironAiken2 ironAiken2 force-pushed the feat/webserver-conf-for-kernel-list branch from 7bb2eff to 962ee77 Compare February 12, 2025 06:49
@ironAiken2 ironAiken2 changed the title feat: set webserver config for showing kernel list in session detail panel feat(BA-722): set webserver config for showing kernel list in session detail panel Feb 12, 2025
@ironAiken2 ironAiken2 marked this pull request as ready for review February 12, 2025 06:52
agatha197
agatha197 approved these changes Feb 17, 2025
View reviewed changes
Copy link
Contributor

@agatha197 agatha197 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@HyeockJinKim HyeockJinKim added this pull request to the merge queue Feb 18, 2025
Merged via the queue into main with commit 0df5431 Feb 18, 2025
25 checks passed
@HyeockJinKim HyeockJinKim deleted the feat/webserver-conf-for-kernel-list branch February 18, 2025 06:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@HyeockJinKim HyeockJinKim HyeockJinKim approved these changes

@agatha197 agatha197 agatha197 approved these changes

@yomybaby yomybaby Awaiting requested review from yomybaby

Assignees

@ironAiken2 ironAiken2

Labels
comp:webserver Related to Web Server component size:S 10~30 LoC
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Need to add the ability to enable kernel list inside session detail panel to webserver.conf.
3 participants
@ironAiken2 @HyeockJinKim @agatha197